kinow commented on pull request #205:
URL:
https://github.com/apache/commons-collections/pull/205#issuecomment-759749343
Hi @arturobernalg , happy 2021!
> I tried to prove the Jira and was not possible. I think it's working
correctly.
From the JIRA description, it sounded to me like we would get an empty list
when it was not desired. So that was the issue/problem we would need to fix for
the next release.
> For some reason @garydgregory suggested adding the test. I guess its
related with my last question about the regression
I think what Gary meant, is that along what I explained above, that if we
indeed have an issue, it is really good if the person that created the JIRA
issue can provide a unit test, and/or some small code snippet to show the
developers what needs to be fixed.
For example, if you have a JIRA-1234 issue, where it says "Serializing an
empty list results in an Exception", then it would be nice if the person
reporting could include some code or unit test like
```java
@Test
public void testEmptyListSerializationIssue() {
// NOTE: we are not testing assertThrows(() -> {...}) here, as the test
is for "how should the API behave", and
// not "how the API is behaving now"
UtilCode.serialize(new SomeCollectionsClass();
}
```
Hope it helps
Bruno
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
