kinow commented on pull request #114: URL: https://github.com/apache/commons-imaging/pull/114#issuecomment-763179912
> > Also, there are several commits. Would it be possible to rebase, and squash the commits? Unless you think it would be better to leave this way for now to edit commits if necessary during the review. > > At my workplace on the Github-Enterprise we have the option to squash-merge in Github itself when merging PRs (we even made that mandatory in the settings). Doesn't this method exist here? Not sure. A committer when merging (when s/he remembers) will squash the commits, normally manually (that's how I do it, with `git` command line locally). One issue with commiters merging (and not the contributor) is that there are some complex issues where it might be better to have more than 1 commit too. But in those cases, the committer might not be aware, and squash everything down to a single commit. Another issue is when the PR takes a while to be merged. If there's any large-ish PR merged first, fixing conflicts in multiple commits may be complicated (or it may be helpful too). In that case, the contributor's code could have an issue that happened during the merge process, not from the contributor code. We ask contributors to squash the commits down to the minimum or a reasonable number of commits, but in cases where it's hard (we know and appreciate the contribution, and understand some times it's hard to find spare time to rebase/squash or do other chores for the ASF review process :-) we can take care of that too :+1: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
