Brixomatic commented on pull request #114:
URL: https://github.com/apache/commons-imaging/pull/114#issuecomment-763184894


   > One issue with commiters merging (and not the contributor) is that there 
are some complex issues where it might be better to have more than 1 commit 
too. But in those cases, the committer might not be aware, and squash 
everything down to a single commit.
   
   I am totally fine with having everything squashed to a single commit, I 
haven't seen a PR that collides.
   And if there is a collision, I'm happy to solve it until it's mergeable.
   I'm just reluctant to mess up the history with a squash on a public branch. 
That should have been made when the branch was still local. 
   By the way, is there a file that contains the formatting rules for use in 
Eclipse or another IDE? I had to have the build done on Github to see whether 
the lint check was passed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to