[
https://issues.apache.org/jira/browse/FILEUPLOAD-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270251#comment-17270251
]
Jochen Wiedmann commented on FILEUPLOAD-293:
--------------------------------------------
There is, in my opinion, no real difference between
a) Replacing an old version with a new version, that no longer contains
this regression, and
b) Changing the code, that invokes DiskFileItem.write() to perform the
necessary check, that prevents the Exception.
This applies, even if you are "an Atlassian developer".
> FileExistsException: Destination .. already exists when DiskFileItem.write
> was given an existing file
> -----------------------------------------------------------------------------------------------------
>
> Key: FILEUPLOAD-293
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-293
> Project: Commons FileUpload
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Mladen Girazovski
> Assignee: Jochen Wiedmann
> Priority: Major
> Fix For: 1.4.1
>
>
> Since 1.4, where FILEUPLOAD-248 was shipped, passing an existing file to
> DiskFileItem.write will cause an FileExistsException with the message
> "Destination FILE already exist", this prevents us from upgrading to 1.4 from
> 1.3.3.
>
> {{2019-02-20 01:12:56,504 http-nio-2990-exec-3 ERROR
> [|5ccb9b99-a96f-42ba-ad01-ac278516e1a4|]
> [IssueAttachmentsResource.privacy-safe] Error saving attachment}}
> {{org.apache.commons.io.FileExistsException: Destination
> '/buildeng/bamboo-agent-home/xml-data/build-dir/CLOUDRELEASE-AGILEWD15421-FT18/jira-test-runner-jira/target/cargo/configurations/tomcat9x/temp/attachment-3404789743778163937.tmp'
> already exists}}
> {{ at org.apache.commons.io.FileUtils.moveFile(FileUtils.java:3001)}}
> {{ at
> org.apache.commons.fileupload.disk.DiskFileItem.write(DiskFileItem.java:405)}}
> {{ at
> com.atlassian.plugins.rest.common.multipart.fileupload.CommonsFileUploadFilePart.write(CommonsFileUploadFilePart.java:49)}}
> {{ at
> com.atlassian.jira.rest.v2.issue.IssueAttachmentsResource.getFileFromFilePart(IssueAttachmentsResource.java:175)}}
> {{...}}
>
> Apache Felix also ran into the same bug:
> https://issues.apache.org/jira/browse/FELIX-6037
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
