garydgregory commented on a change in pull request #210:
URL:
https://github.com/apache/commons-collections/pull/210#discussion_r569495027
##########
File path: src/main/java/org/apache/commons/collections4/ListUtils.java
##########
@@ -539,7 +538,7 @@ public static int hashCodeForList(final Collection<?> list)
{
}
}
}
- return -1;
+ return ArrayUtils.INDEX_NOT_FOUND;
Review comment:
Hi @arturobernalg
I think you can replace `ArrayUtils.INDEX_NOT_FOUND` with
`CollectionUtils.INDEX_NOT_FOUND` and delete `ArrayUtils.INDEX_NOT_FOUND` since
it is package private. Just make sure you use a better comment for
`CollectionUtils.INDEX_NOT_FOUND` like the one for `ArrayUtils.INDEX_NOT_FOUND`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
