[ 
https://issues.apache.org/jira/browse/POOL-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278644#comment-17278644
 ] 

Ashok Goli commented on POOL-282:
---------------------------------

I began implementing AbandonedConfig Implementation for GenericKeyedObjectPool. 
Since we have multiple pools, I wanted to create a separate 
KeyedAbandonedConfig specific to GenericKeyedObjectPool. I'm a lil confused on 
the below things. :
 * Global vs Per Key abandonment configurations - I think all configs should be 
per key as borrow and return happens per key.
 * Right now I have removeAbandonedOnBorrowPerKey, 
removeAbandonedOnMaintenancePerKey and removeAbandonedTimeoutPerKey in a new 
Class KeyedAbandonedConfig instead of removeAbandonedOnBorrow, 
removeAbandonedOnMaintenance, removeAbandonedTimeout present in 
AbandonedConfig. Is this good or should I retain the global configs and loop 
all keyed pools for every borrow & maintainance instead of per-key checks?
 * Any other considerations that need to be baked into the implementation

Any direction by the expert devs of commons-pool2 will be much appreciated

> CLONE - Support AbandonedConfig in SharedPoolDataSource
> -------------------------------------------------------
>
>                 Key: POOL-282
>                 URL: https://issues.apache.org/jira/browse/POOL-282
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: 2.0, 2.1, 2.2, 2.3
>         Environment: Linux and Java 1.6
>            Reporter: Michael Kerr
>            Priority: Minor
>              Labels: features
>
> BasicDataSource has support for AbandonedConfig
> SharedPoolDataSource does not currently support reclaiming abandoned 
> connections.
> It would be helpful if the user can extend the underlying connection pool to 
> add features like abandoned connection management.  This is possible with 
> BasicDataSource.
> Currently the only solution is to extend classes or replace classes in the 
> Apache package namespace.
> Thanks for looking,
> Michael



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to