[
https://issues.apache.org/jira/browse/IO-719?focusedWorklogId=550468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550468
]
ASF GitHub Bot logged work on IO-719:
-------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/21 22:43
Start Date: 09/Feb/21 22:43
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #203:
URL: https://github.com/apache/commons-io/pull/203#discussion_r573300829
##########
File path: src/main/java/org/apache/commons/io/file/CopyDirectoryVisitor.java
##########
@@ -153,7 +155,7 @@ public FileVisitResult preVisitDirectory(final Path
directory, final BasicFileAt
@Override
public FileVisitResult visitFile(final Path sourceFile, final
BasicFileAttributes attributes) throws IOException {
- final Path targetFile =
targetDirectory.resolve(sourceDirectory.relativize(sourceFile));
+ final Path targetFile =
targetDirectory.resolve(sourceDirectory.relativize(sourceFile).toString());
Review comment:
As above...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 550468)
Time Spent: 1h (was: 50m)
> PathUtils.copyDirectory() does not work when source and dest belong to
> different filesystems
> --------------------------------------------------------------------------------------------
>
> Key: IO-719
> URL: https://issues.apache.org/jira/browse/IO-719
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 2.8.0
> Environment: Java 8, Linux
> Reporter: Andrew Shcheglov
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This code:
> {code:java}
> @Test
> public void pathUtilsCopyDirFailure() throws IOException {
> FileSystem fs1 = Jimfs.newFileSystem();
> Path srcDir = fs1.getPath("srcDir");
> // Create files/dirs in srcDir
> Path targetDir = Paths.get("targetDir");
> PathUtils.copyDirectory(srcDir, targetDir);
> }
> {code}
> throws exception:
> {noformat}
> java.nio.file.ProviderMismatchException
> at java.base/sun.nio.fs.UnixPath.toUnixPath(UnixPath.java:198)
> at java.base/sun.nio.fs.UnixPath.resolve(UnixPath.java:410)
> at java.base/sun.nio.fs.UnixPath.resolve(UnixPath.java:43)
> at
> org.apache.commons.io.file.CopyDirectoryVisitor.preVisitDirectory(CopyDirectoryVisitor.java:130)
> at
> org.apache.commons.io.file.CopyDirectoryVisitor.preVisitDirectory(CopyDirectoryVisitor.java:36)
> at java.base/java.nio.file.Files.walkFileTree(Files.java:2731)
> at java.base/java.nio.file.Files.walkFileTree(Files.java:2796)
> at
> org.apache.commons.io.file.PathUtils.visitFileTree(PathUtils.java:687)
> at
> org.apache.commons.io.file.PathUtils.copyDirectory(PathUtils.java:196)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
