garydgregory commented on a change in pull request #67:
URL: https://github.com/apache/commons-pool/pull/67#discussion_r583644635
##########
File path:
src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
##########
@@ -267,6 +272,25 @@ public GenericKeyedObjectPool(final
KeyedPooledObjectFactory<K, T> factory,
setConfig(config);
}
+ /**
+ * Creates a new {@code GenericKeyedObjectPool} that tracks and destroys
+ * objects that are checked out, but never returned to the pool.
+ *
+ * @param factory The object factory to be used to create object
instances
+ * used by this pool
+ * @param config The base pool configuration to use for this pool
instance.
+ * The configuration is used by value. Subsequent changes
to
+ * the configuration object will not be reflected in the
+ * pool.
+ * @param abandonedConfig Configuration for abandoned object
identification
+ * and removal. The configuration is used by
value.
+ */
Review comment:
Just reviewing details: Please add `@since` tags to new public and
protected methods.
##########
File path:
src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java
##########
@@ -91,6 +91,12 @@
*/
boolean getLifo();
+ /**
Review comment:
You MUST use default methods when adding to an interface in order to
preserve binary compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
