bodewig commented on pull request #169: URL: https://github.com/apache/commons-compress/pull/169#issuecomment-787053225
I like the code change. It is good you always include a central directory zip64 when there has been one in LFH, something I likely would have overlooked. Thanks. The javadoc of the new option is not completely accurate, as it will always add zip64 entries to the central directory, but not necessarily encode the disk number and relative offset. Oh, I believe we are overlooking something. We must ensure we add the relative LFH offset to the Zip64 extended information entry inside the central directory even if it is not too big in the case where the disk number is too big - or we'd create a gap inside of the extra field. This is currently wrong inside master as well, unless I'm wrong. I don't like the name of the new option, but I'm the last one who should suggest a different one - I've got a long track record of picking bad names. Let's discuss this on the dev list. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
