[ 
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560839&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560839
 ]

ASF GitHub Bot logged work on LANG-1644:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Mar/21 06:26
            Start Date: 04/Mar/21 06:26
    Worklog Time Spent: 10m 
      Work Description: arturobernalg commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-790332374


   > BigInteger
   
   Hi @aherbert 
   
   Thank you for your comment. I've fix those cases that you mentioned and i've 
add more test.
   
   Just one think about --> `0x1L`. I don't know what to do with that. If you 
execute the test `compareIsNumberWithCreateNumber("0x1L", true)`; will throw an 
exception. Same case with 
   
   `NumberUtils.isParsable("0x1L") 
   `


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 560839)
    Time Spent: 1.5h  (was: 1h 20m)

> Check if number is hexadecimal
> ------------------------------
>
>                 Key: LANG-1644
>                 URL: https://issues.apache.org/jira/browse/LANG-1644
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Arturo Bernal
>            Priority: Minor
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> IMO would be fine have a method that given a String tell you if is a valid 
> hexadecimal number instead of try to create the number. should be valid:
>  
>  * 5D0
>  * 0x7FFFFFFFFFFFFFFF
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to