arturobernalg commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-790832106
> Regarding `0x1L` the NumberUtils.createNumber and NumberUtils.isCreatable
only supports the preferred type suffix on decimal numbers. You cannot specify
a preferred `L` for hex integers. So this new method should match the existing
behaviour of those methods. So you can ignore this.
>
> I am not sure that allowing the number `5D0` to be `true` is valid. This
would not be parsed or created as a Hex integer by any method in NumberUtils.
`Integer.decode("5D0")` throws an exception. Thus a hex number should be
identified with `0x`, `0X` or `#` with an optional sign prefix (see [LANG-1645]
and #728) and thereafter only contain the digits `[0-9A-Fa-f]`.
>
> This method then becomes a subset of `isCreateable` that will return true
only if the `Number` created by `createNumber` is a mathematical integer.
HI @aherbert
Depends on what we want to achieve with the method. `5D0` it's a valid hex
and IMO should be considered for the method and returned true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
