[ 
https://issues.apache.org/jira/browse/COMPRESS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296739#comment-17296739
 ] 

Björn Michael commented on COMPRESS-552:
----------------------------------------

{quote}Could you provide some test to reproduce this problem?
{quote}
I'm afraid that I don't know how to write a narrow-scoped small osgi env. unit 
test.

 
{quote}So the only way out would be a Bundle-Activator?
{quote}
The easiest way would be to add
{code:java}
Import-Package: org.osgi.framework;resolution:=optional
{code}
to {{MANIFEST.MF}}.
 I also like the "classloader implements 
{{org.osgi.framework.BundleReference"}} check 
([https://stackoverflow.com/a/5884211/1061929]).
 But instead of an {{instanceof}} check that requires the class object of 
{{BundleReference}} at compile and runtime, one could compare the classloaders 
interface (and super interface) names to {{org.osgi.framework.BundleReference}} 
by {{java.lang.Class.getName()}}.

> OSGI check broken - try to load class BundleEvent always fails
> --------------------------------------------------------------
>
>                 Key: COMPRESS-552
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-552
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Compressors
>    Affects Versions: 1.20
>            Reporter: Björn Michael
>            Priority: Major
>
> There is a check for running in OSGI env. in {{ZstdUtils}}, {{BrotliUtils}}, 
> {{LZMAUtils}} and {{XZUtils}} like this:
> {code:java}
> static {
>     cachedZstdAvailability = CachedAvailability.DONT_CACHE;
>     try {
>         Class.forName("org.osgi.framework.BundleEvent");
>     } catch (final Exception ex) { // NOSONAR
>         setCacheZstdAvailablity(true);
>     }
> }
> {code}
> Loading the class {{org.osgi.framework.BundleEvent}} always fails because 
> {{Import-Package}} directive for {{org.osgi.framework}} is missing in 
> _MANIFEST.MF_. Or it requires another more sophisticated approach 
> (https://stackoverflow.com/q/5879040/1061929).
> Tested with Eclipse 4.14 (org.eclipse.osgi_3.15.100.v20191114-1701.jar)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to