MaxKellermann commented on pull request #155: URL: https://github.com/apache/commons-vfs/pull/155#issuecomment-796679342
OK, it looks like the commons-vfs code assumes that any stream object must be closed by the same thread that opened it. But this requirement doesn't appear to be documented, and doesn't make a lot of sense - why not move a stream object to another thread? A sane library should allow that, but as I said: commons-vfs has been buggy all along, and my patch only revealed that existing bug. I could easily add a `null` check which would make the symptom go away, but this doesn't solve the real bug, so I don't like doing that. On the other hand, fixing the real problem may mean removing the whole ThreadLocal logic, because it's inherently broken. @garydgregory what is your opinion on this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
