[
https://issues.apache.org/jira/browse/IMAGING-168?focusedWorklogId=565961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-565961
]
ASF GitHub Bot logged work on IMAGING-168:
------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/21 20:39
Start Date: 14/Mar/21 20:39
Worklog Time Spent: 10m
Work Description: yavuzkavus commented on a change in pull request #124:
URL: https://github.com/apache/commons-imaging/pull/124#discussion_r593957568
##########
File path:
src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java
##########
@@ -202,6 +209,11 @@ public PhotoshopApp13Data parsePhotoshopSegment(final
byte[] bytes, final boolea
// Debug.debug("recordSize", recordSize + " (0x"
// + Integer.toHexString(recordSize) + ")");
+ if( recordNumber==IptcConstants.IPTC_ENVELOPE_RECORD_NUMBER &&
recordType==ENV_TAG_CODED_CHARACTER_SET ) {
Review comment:
Yes, there some others :) For example, there is not space between if and
opening paranthes. I fixed all. I pushed the new changes.
There have been many commits for this change. If it is merged, is it
possible to convert it as single commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 565961)
Time Spent: 3.5h (was: 3h 20m)
> IPTC parser should use CodedCharacterSet tag to determine encoding of the
> IPTC tag values
> -----------------------------------------------------------------------------------------
>
> Key: IMAGING-168
> URL: https://issues.apache.org/jira/browse/IMAGING-168
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: JPEG
> Affects Versions: 1.0-alpha2
> Reporter: sudeep khemka
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Fix For: 1.0-alpha3
>
> Attachments: codedCharacterSet.patch
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> The IPTC CodedCharacterSet tag can be used to specify the encoding of the
> IPTC tag values. But the setting is currently ignored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
