[
https://issues.apache.org/jira/browse/MATH-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303348#comment-17303348
]
Gilles Sadowski edited comment on MATH-1567 at 3/17/21, 12:25 PM:
------------------------------------------------------------------
You should verify that updates don't break the build...
Also:
* Please follow the style convention (one space around operators, "final" for
constants, 4-spaces indentation)
* Full documentation is mandatory (there is a missing {{@return}} tag)
* In Junit test: Why the use of {{NumberFormat}} (rather than the usual
tolerance parameter)?
* No trailing white space
Many checks are automatically perfomed if you create a pull request through
[GitHub|https://github.com/apache/commons-math/].
was (Author: erans):
You should verify that updates don't break the build...
Also:
* Please follow the style convention (one space around operators, "final" for
constants, 4-spaces indentation, ...),
* Full documentation is mandatory (there is a missing {{@return}} tag)
* In Junit test: Why the use of {{NumberFormat}} (rather than the usual
tolerance parameter)?
* No trailing white space
> Harmonic Mean Calculation
> -------------------------
>
> Key: MATH-1567
> URL: https://issues.apache.org/jira/browse/MATH-1567
> Project: Commons Math
> Issue Type: New Feature
> Affects Versions: 3.6.1
> Reporter: Hasan Diwan
> Priority: Trivial
> Labels: easyfix, newbie, patch
> Fix For: 4.0
>
> Attachments: harmonicMean.pat
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Patch adds harmonic mean support to StatsUtils.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
