[
https://issues.apache.org/jira/browse/GEOMETRY-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308670#comment-17308670
]
Matt Juntunen commented on GEOMETRY-118:
----------------------------------------
A few points here:
* Thanks for the PR!
* The methods should use the naming convention {{applyX}} and {{applyY}} to
match the other methods that apply the transformation.
* Let's remove the one argument versions of the method and just stick with the
two-argument versions. IMHO, having multiple versions of the methods is
confusing and not very helpful. (For example, in order to properly call the
one-argument method with proper error checking, you would need to check the
value of m01 before each use.) The two argument version is correct in all cases
so let's stick with that. If users want to optimize for specific use cases,
they can do that in their own application code.
* We need unit tests. Code coverage should be 100% for this class.
* We should also add this functionality (along with unit tests) to
{{AffineTransformMatrix3D}}.
> AffineTransformMatrix2D should support direct transformation of x/y values
> --------------------------------------------------------------------------
>
> Key: GEOMETRY-118
> URL: https://issues.apache.org/jira/browse/GEOMETRY-118
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
>
> [~mattjuntunen] as discussed on the mailinglist, it would be convenient if
> there would be methods to directly transform a single x/y value instead of
> using vectors and/or export the matrix as an array and perform it manually.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
