[ 
https://issues.apache.org/jira/browse/GEOMETRY-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308676#comment-17308676
 ] 

Matt Juntunen commented on GEOMETRY-117:
----------------------------------------

Again, thanks for the PR!

We need a few updates before we can merge this in:
- Add units tests, as mentioned by [~erans].
- Add a {{createShear}} static factory method, similar to the 
{{createTranslation}}, {{createRotation}}, etc methods.

Also note, our convention in the codebase is to use the {{final}} keyword on 
every method parameter and variable applicable.

> AffineTransformMatrix2D should support shear transform
> ------------------------------------------------------
>
>                 Key: GEOMETRY-117
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-117
>             Project: Apache Commons Geometry
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> As discussed on the mailinglist, a shear method would be usefull



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to