[
http://jira.codehaus.org/browse/CONTINUUM-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brett Porter updated CONTINUUM-1127:
------------------------------------
Affects Version/s: 1.3.2
Fix Version/s: 1.x
> logic for whether to build is confusing
> ---------------------------------------
>
> Key: CONTINUUM-1127
> URL: http://jira.codehaus.org/browse/CONTINUUM-1127
> Project: Continuum
> Issue Type: Bug
> Components: Core system
> Affects Versions: 1.1-alpha-1, 1.3.2
> Reporter: Brett Porter
> Fix For: 1.x
>
>
> Looking at the logic in DefaultBuildcontroller's shouldBuild( BuildContext
> context ), I see some potential problems:
> - the second else clause is redundant - shouldBuild is always true at this
> point
> - the code is confusing - better to default to false, then set to true if
> state/oldstate is new or checkedout, or if the build was forced
> - move the dependency checking outside the other if. It doesn't need to be
> conditional on whether there were changes or not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
