[
http://jira.codehaus.org/browse/CONTINUUM-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=177012#action_177012
]
Jose Morales Martinez commented on CONTINUUM-2195:
--------------------------------------------------
Sorry, but I think I have not explained:
Currently only when we enable a schedule we add a job to scheduler(application
scheduler- quartz ). Performing the following checks:
{noformat}
if ( isScheduleFromBuildJob( schedule ) )
{
// A buildDefinition with this schedule
schedule( schedule, continuum, ContinuumBuildJob.class );
}
if ( isScheduleFromPurgeJob( schedule ) )
{
// A purge with this schedule
schedule( schedule, continuum, ContinuumPurgeJob.class );
}
{noformat}
That way if the schedule is not linked to a buildDefinition or
purgeConfiguration not work for them. After set a schedule for a
buildDefinition/purgeConfiguration we need to update the schedule to add job(s)
to application scheduler.
In this way, my options are:
1 - Always add the job (buildDefinition and purgeConfiguration) to the
scheduler. Simpler and does not modify the code to buildDefinition and
purgeConfiguration
2 - When a store purgeConfiguration / buildDefinition set a schedule we add job
to application scheduler. More efficient (the scheduler only contains the jobs
to be executed)
3 - Add a single job for application scheduler and its execution launch a
thread for builds and other for purge. This solution is similar to the first.
> adding a new schedule does not work on first activation
> -------------------------------------------------------
>
> Key: CONTINUUM-2195
> URL: http://jira.codehaus.org/browse/CONTINUUM-2195
> Project: Continuum
> Issue Type: Bug
> Components: Core system
> Affects Versions: 1.4.0
> Reporter: Brett Porter
> Assignee: Jose Morales Martinez
> Fix For: 1.x
>
>
> When the schedule was first created (with no projects assigned), it was
> "activated". However, after assigning a project to it, it did not fire.
> Editing the schedule (no changes made), caused it to fire on the assigned
> project. The log is as follows:
> {code}
> 2009-04-22 20:03:51,005 [btpool0-1] INFO
> org.apache.maven.continuum.build.settings.DefaultSchedulesActivator -
> Activating schedule minutely
> 2009-04-22 20:37:13,488 [btpool0-7] INFO
> org.apache.maven.continuum.build.settings.DefaultSchedulesActivator -
> Deactivating schedule minutely
> 2009-04-22 20:37:13,488 [btpool0-7] INFO
> org.apache.maven.continuum.build.settings.DefaultSchedulesActivator -
> Stopping active schedule "minutely".
> 2009-04-22 20:37:13,488 [btpool0-7] INFO
> org.apache.maven.continuum.build.settings.DefaultSchedulesActivator -
> Activating schedule minutely
> 2009-04-22 20:37:13,494 [btpool0-7] INFO
> org.apache.maven.continuum.build.settings.DefaultSchedulesActivator -
> minutely: next fire time ->Wed Apr 22 20:38:00 EST 2009
> 2009-04-22 20:38:00,019 [continuumScheduler_Worker-4] INFO
> org.apache.maven.continuum.build.settings.DefaultSchedulesActivator -
> >>>>>>>>>>>>>>>>>>>>> Executing build job (minutely)...
> {code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
