[
http://jira.codehaus.org/browse/CONTINUUM-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180332#action_180332
]
Wendy Smoak commented on CONTINUUM-565:
---------------------------------------
2009-05-14 irc conversation from my logs:
[4:56pm] wsmoak: does anyone know how anything actually gets *built* in
Continuum?
[4:56pm] wsmoak: all I want to do is add "by <whoever>" on the build results
page to show who forced a build
[4:57pm] brett: there's a build executor in core
[4:57pm] brett: you probably want to do a find usages on the add method of the
build result dao
[4:57pm] wsmoak: BuildProjectTaskExecutor is one of the things I found
[4:58pm] brett: that's him
[4:58pm] wsmoak: all he does is call controller.build
[4:59pm] wsmoak: BuildController is an interface
[4:59pm] wsmoak: where's the *code* for pete's sake
[4:59pm] brett: :)
[4:59pm] wsmoak: there's no 'add' in the BuildResult class
[4:59pm] brett: BR, or BRDao?
[5:00pm] brett: if you're in eclipse, you can get an outline on the interface
cass that shows subclasses
[5:01pm] wsmoak: just BR. hadn't found the Dao one.
[5:01pm] wsmoak: yeah, alt-F7
[5:02pm] wsmoak: DefaultBuildController. possibly.
[5:05pm] marica joined the chat room.
[5:07pm] wsmoak: looks like it would mean changing a method signature on
DefaultBuildController.build.
[5:08pm] wsmoak: last time I tried something like that, it rippled through the
entire app.
[5:09pm] brett: yah
[5:09pm] brett: it doesn't take a context of extra info?
[5:11pm] wsmoak: not afaict - public void build( int projectId, int
buildDefinitionId, int trigger, ScmResult scmResult )
[5:12pm] brett: boo
[5:12pm] brett: trigger should be a class
[5:12pm] wsmoak: there's private void updateBuildResult( BuildContext context,
String error ) that has a context...
[5:12pm] brett: might only be called on error
[5:14pm] wsmoak: darn. the build context gets *created* inside this class, it
isn't passed in
[5:14pm] wsmoak: so... turn Trigger into a class and see what else has to
change...
[5:14pm] brett: (everything)
[5:14pm] brett: :p
[5:15pm] wsmoak: yeah. here's the part where I decide changing stuff in
continuum is way too hard and just go open more issues
[5:15pm] brett: I would probably overload it, not change it
[5:16pm] wsmoak: yeah. but I bet it's still going to be messy changing it on
the other side where things are calling it.
[5:18pm] wsmoak: hm. we may be in luck... the only usage I can find is the
aforementioned controller.build(...) in BuildProjectTaskExecutor
[5:19pm] wsmoak: which means BuildProjectTask has to change... and we'll leave
figuring out who fills him up for another day
[5:22pm] wsmoak: thanks :)
> Forced builds should say who (which continuum user) forced the build
> --------------------------------------------------------------------
>
> Key: CONTINUUM-565
> URL: http://jira.codehaus.org/browse/CONTINUUM-565
> Project: Continuum
> Issue Type: Improvement
> Components: Core system
> Reporter: Jamie Flournoy
> Priority: Minor
> Fix For: 1.x
>
>
> Currently if a build is forced the build history and notifications don't say
> who forced it. It would be nice if that was part of the history and
> notifications.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
