[ 
https://jira.codehaus.org/browse/CONTINUUM-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=364258#comment-364258
 ] 

Brent N Atkinson edited comment on CONTINUUM-2578 at 2/28/15 12:22 PM:
-----------------------------------------------------------------------

The patch no longer applied cleanly, but I was able to adapt it to the current 
codebase. However, after initial testing this does not appear to have a 
perceivable effect.

When I tested, the scm checkout successfully used the username and password 
from settings. However, this is unrelated and existing behavior and was a side 
effect of testing on a server that allowed anonymous access as well as 
authenticated. My understanding is that the technique is inadequate in its 
approach:

  * Correct scm configuration requires construction of the maven project 
metadata (a {{MavenProject}})
  * The {{MavenProject}} is built from a pom 
  * Continuum can not access the pom without a correct username and password

Looking careful at the patch, the scm url is identified by using the maven 
project. This can not be correct.


was (Author: batkinson):
The patch no longer applied cleanly, but I was able to adapt it to the current 
codebase. However, after initial testing this does not appear to have a 
perceivable effect.

When I tested, the scm checkout successfully used the username and password 
from settings. However, this is unrelated and existing behavior and was a side 
effect of testing on a server that allowed anonymous access as well as 
authenticated. My understanding is that the technique is inadequate in its 
approach:

  * Correct scm configuration requires construction of the maven project 
metadata (a {{MavenProject}})
  * The {{MavenProject}} is built from a pom 
  * Continuum can not access the pom without a correct username and password

Looking carefull at the patch, the scm url is identified by using the maven 
project. This can not be correct.

> Configure SCM username/password from settings.xml doesn't work for xmlrpc
> -------------------------------------------------------------------------
>
>                 Key: CONTINUUM-2578
>                 URL: https://jira.codehaus.org/browse/CONTINUUM-2578
>             Project: Continuum
>          Issue Type: New Feature
>            Reporter: Luca
>            Assignee: Brent N Atkinson
>             Fix For: 1.5.0
>
>         Attachments: configure-scm-credentials-from-settings.diff
>
>
> The attached patch is to configure the scm username/password from 
> settings.xml when building a project from a pom file. It attempts to match 
> the SCM server host name to the id of a server in the <servers> section.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to