[
https://issues.apache.org/jira/browse/CB-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694158#comment-13694158
]
Steve Gill commented on CB-3971:
--------------------------------
Just took a look at the pull request. It looks like you are doing this work on
cordova-android master. I would recommend against doing this.
Right after 2.9.0, we are switching over to using the 3.0 branches that exsit
for each of the platforms. You will notice that no plugins exist on those
branches.
I recommend that these changes instead happen on the new plugin repos.
For vibration, checkout
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-vibration.git;a=summary.
For dialogs, checkout
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;a=summary.
To test these, checkout the 3.0 branch for android, create a example project by
using the create script and then use the latest plugman to install the plugins
into the example app. Copy the plugins test directoires into the www folder (or
copy in mobile spec).
In the vibration repo, feel free to rename notification.java to vibration.java
and make the changes you made in your pull request there. The javascript in
that repo will also have to be renamed away from notification.
Lets discuss more on irc.
> Breakout notification/dialog plugin from vibration plugin
> ---------------------------------------------------------
>
> Key: CB-3971
> URL: https://issues.apache.org/jira/browse/CB-3971
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Android, BlackBerry, iOS, Plugin Dialogs, Plugin
> Vibration, WP7, WP8
> Reporter: Steve Gill
> Fix For: 3.0.0
>
>
> Currently the notification plugin and the vibration plugin are in one file.
> We need to break these out into two separate plugins. I believe we can
> accomplish this before 3.0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
