breautek commented on pull request #918: URL: https://github.com/apache/cordova-android/pull/918#issuecomment-646058710
Thank you for your contribution, but is PR cannot be accepted for a few different reasons: - Android webview already has support for web sockets. - The licenses are not valid for the apache project. You can't just copy other peoples code. [Original Code](https://github.com/apache/cordova-android/tree/WebSockets) - The implementation of this web socket doesn't appear to be updated to the latest standard, it appears to be based on an older draft. If there was a bug that this PR was attempting to solve, I'd advise opening up a bug ticket first ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
