timbru31 commented on a change in pull request #141:
URL:
https://github.com/apache/cordova-plugin-dialogs/pull/141#discussion_r448488854
##########
File path: www/notification.js
##########
@@ -103,19 +106,24 @@ module.exports = {
*/
beep: function (count) {
var defaultedCount = count || 1;
- exec(null, null, 'Notification', 'beep', [ defaultedCount ]);
+ exec(null, null, 'Notification', 'beep', [defaultedCount]);
}
};
function convertButtonLabels (buttonLabels) {
-
// Some platforms take an array of button label names.
// Other platforms take a comma separated list.
// For compatibility, we convert to the desired type based on the platform.
- if (platform.id === 'amazon-fireos' || platform.id === 'android' ||
platform.id === 'ios' ||
- platform.id === 'windowsphone' || platform.id === 'firefoxos' ||
platform.id === 'ubuntu' ||
- platform.id === 'windows8' || platform.id === 'windows') {
-
+ if (
+ platform.id === 'amazon-fireos' ||
Review comment:
Follow-up PR to remove this will follow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
