raphinesse opened a new pull request #1014: URL: https://github.com/apache/cordova-android/pull/1014
### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> The current _is path a inside path b_ check relies solely on prefix checking. In general, that is not robust enough. A real-world example where it fails, is when `Api.createPlatform` is called with a `destination` that is outside of `process.cwd()`. For example a temp dir during a test. This occurred when refactoring E2E tests. This relies on proper test cleanup as implemented in #1013. ### Description <!-- Describe your changes in detail --> Use `is-path-inside` library. ### Testing <!-- Please describe in detail how you tested your changes. --> - `Api.createPlatform` now works as expected - added regression test ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
