erisu opened a new pull request #158:
URL: https://github.com/apache/cordova-electron/pull/158


   ### Motivation, Context & Description
   
   Some build targets has configurations and are stored in a top-level key.
   
   For example: if the target `dmg` is set, there is a `top-level` node in the 
configuration structure called `dmg` which contains its configurations.
   
   Not all `top-level` keys match the `target` key. 
   
   For example: `nsis-web` target key actually has a top-level key of `nsisWeb`
   
   This PR adds a target key to top-level key mapping. If the target key exists 
in this mapping, it will use the defined top-level key else fall back to the 
target key.
   
   ### Testing
   
   - `npm t`
   - `cordova platform add`
   - `cordova build electron`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to