breautek commented on a change in pull request #126:
URL:
https://github.com/apache/cordova-plugin-device/pull/126#discussion_r456070547
##########
File path: plugin.xml
##########
@@ -37,10 +37,14 @@
<!-- android -->
<platform name="android">
<config-file target="res/xml/config.xml" parent="/*">
- <feature name="Device" >
+ <feature name="Device">
<param name="android-package"
value="org.apache.cordova.device.Device"/>
</feature>
</config-file>
+ <config-file target="AndroidManifest.xml" parent="/*">
+ <uses-permission
android:name="android.permission.READ_PHONE_STATE"/>
+ <uses-permission
android:name="android.permission.READ_PRIVILEGED_PHONE_STATE"/>
Review comment:
Cordova cannot define privileged permissions because that would cause
apps to be rejected from the Google Play store.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
