[ 
https://issues.apache.org/jira/browse/CB-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718857#comment-13718857
 ] 

Shazron Abdullah edited comment on CB-4355 at 7/24/13 9:36 PM:
---------------------------------------------------------------

I'm tempted to add another new selector in the CDVCommandDelegate for 
"settingForKey" but since we broke out all the plugins into their own repos, 
versioning might be tricky and break usage.

Basically if I add this selector in 3.1, and CDVSplashScreen uses it, someone 
on 3.0 grabbing the code will not be able to compile it. The <engines> tag on 
plugin.xml should be able to support this case I think, not sure. 
                
      was (Author: shazron):
    I'm tempted to add another new selector in the CDVCommandDelegate for 
"settingForKey" but since we broke out all the plugins into their own repos, 
versioning might be tricky and break usage.
                  
> Splashscreen plugin handles options incorrectly (the settings key is 
> specified with upper case chars)
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CB-4355
>                 URL: https://issues.apache.org/jira/browse/CB-4355
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS, Plugin SplashScreen
>    Affects Versions: 3.0.0
>            Reporter: Stephan Wezel
>            Assignee: Shazron Abdullah
>             Fix For: 3.1.0
>
>
> Splashscreen plugin handles options incorrectly (the settings key is 
> specified with upper case chars)
> The config parsers save the options/preferences with a lowercase string of 
> the option name as the key. But the Plugin tries to retreive the option with 
> update cases (e.g. with "AutoHideSplashScreen" instead of 
> autohidesplashscreen)
> Maybe this affects also other plugins as well.
> This bug was caused due this changeset: 
> https://github.com/apache/cordova-ios/commit/a57f467bfdb42a4c17b22f81f744ac445ef0695a

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to