mrbberra opened a new pull request #765:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/765


   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   This allows apps that set a dark status bar background color using 
[cordova-plugin-statusbar](https://github.com/apache/cordova-plugin-statusbar) 
to set the status bar style when using the in app browser. Became necessary 
after [GH-656](https://github.com/apache/cordova-plugin-inappbrowser/pull/656).
   Fixes: #728 
   
   
   
   ### Description
   Adds the ability to set `<preference name="InAppBrowserStatusBarStyle" 
value="lightcontent" />` in the config.xml file, so that the 
`preferredStatusBarStyle` becomes `UIStatusBarStyleLightContent` instead of 
`UIStatusBarStyleDefault`.
   
   
   
   ### Testing
   I created a [test 
app](https://github.com/mrbberra/inappbrowser-statusbar-style) and tried 
setting the InAppBrowserStatusBarStyle to "default", "lightcontent", and 
removing it alltogether. I didn't add any new automatic tests- not sure how.
   
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to