brodybits opened a new pull request #853: URL: https://github.com/apache/cordova-lib/pull/853
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected all ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> From work on PRs #851 and #852, I think the code to show which platforms are deprecated is not so well covered by testing. The following possible code mutation does not seem to trigger any test failures: ```diff --- a/src/cordova/platform/list.js +++ b/src/cordova/platform/list.js @@ -58,7 +58,7 @@ function addDeprecatedInformationToPlatforms (platformsList) { var platformKey = p.split(' ')[0]; // Remove Version Information // allow for 'unknown' platforms, which will not exist in platforms if ((platforms.info[platformKey] || {}).deprecated) { - p = p.concat(' ', '(deprecated)'); + p = p.concat(' ', 'xxx'); } return p; }); ``` ### Description <!-- Describe your changes in detail --> Add `spec/cordova/platform/listDeprecated.spec.js` to test the output in case of any deprecated platforms. ### Testing <!-- Please describe in detail how you tested your changes. --> The above mutation leads to failures in the new test cases. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
