erisu commented on a change in pull request #377:
URL: https://github.com/apache/cordova-windows/pull/377#discussion_r483449083
##########
File path: package.json
##########
@@ -17,11 +17,11 @@
"apache"
],
"scripts": {
- "test": "npm run eslint && npm run test-unit && npm run test-e2e",
+ "test": "npm run lint && npm run test-unit && npm run test-e2e",
"test-unit": "jasmine",
"test-e2e": "jasmine spec/e2e/endtoend.spec.js",
"cover": "nyc jasmine",
- "eslint": "eslint . \"+(bin|template)/**/!(*.*)\""
+ "lint": "eslint . \"+(bin|template)/**/!(*.*|gitignore)\""
Review comment:
if I remember correctly, its because some of the files are not JS files
but are written with JS.. For example `check_all`, `check_req`... Written this
will will force them to be checked as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
