breautek commented on pull request #152: URL: https://github.com/apache/cordova-common/pull/152#issuecomment-687630093
> I googled and noticed there are persons achieved that by creating a temp_config file and copy it in hooks to replace config.xml This would actually be far more safer, in my opinion. Both from the usability standpoint and a maintainability standpoint. Your CI should be able to provide a templated `config.xml` file depending on the project variant that you're building. I think this is far more safer than providing these values from environmental variables where it will be very easy for them to leak into other projects, especially in non-CI environments. I think I understand where you're coming from but I'm concerned about how people will misuse this feature and report issues because of their improper configuration. which will be hard to reproduce because it is harder to replicate an environment, as opposed to simply sharing their `config.xml` file. I understand that in your use case is in a CI build, but I don't think it's right to add a feature that can only really be used for CI builds, and have a high risk of causing breakage and confusion outside of a CI build. I wouldn't have much of a concern if these environment variables actually made sense to be applied to multiple projects, but that's not the case here. Most, if not all of the environment variables you're planning to add only applies to a specific project. Please think about this in a perspective of building a [framework](https://softwareengineering.stackexchange.com/a/133177/259686), then let me know what you think. If you still have an opposing opinion, then that's okay. I'll try to get some feedback from other contributors so that we can figure out the best way forward. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
