raphinesse opened a new pull request #230: URL: https://github.com/apache/cordova-js/pull/230
### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Currently the SHA of the commit pointed by `HEAD` is included in the built cordova.js to identify the version of `cordova-js` used to build it. If platforms depend on `cordova-js` in the future, they will most likely depend on published packages. Consequently there will be no `cordova-js` repo to get aforementioned information from. In that case we now include the version from `package.json` instead ### Description <!-- Describe your changes in detail --> - uses `git describe` instead of `git rev-parse HEAD` if in a `cordova-js` repo - fall back to version from package.json if not in a `cordova-js` repo - rename and factor out `build-id` ### Testing <!-- Please describe in detail how you tested your changes. --> Manually tested both cases. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
