lempere opened a new pull request #1073: URL: https://github.com/apache/cordova-android/pull/1073
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Fix #924 We have a project with 31 plugins installed, in some devices like Huawei p30( or emulator Pixel_3-x86_64 android R) fail starting the app 4 of 10 times. Showing the _ConcurrentModificationException_ error from the **webView.postMessage("splashscreen", "hide");** of the **SplashScreen.java** ### Description <!-- Describe your changes in detail --> Tracking the #924 thread I found a code to avoid the error using [.synchronizedMap](https://github.com/breautek/cordova-android/commit/bfda452a09ba26412e0f527f6af1957379d89453). This was not enough the app still crash sometimes. Then testing using the .forEach instead of the **for (CordovaPlugin plugin : this.pluginMap.values())** works. No more _ConcurrentModificationException_ were thrown. A counterpoint is that .forEach is not available prior android 6 and a check version is needed. ### Testing <!-- Please describe in detail how you tested your changes. --> npm run test Found a device with launch problems. Start the app a lot of times with this pr code, no _ConcurrentModificationException_ happens again. ### Checklist - [X] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [X] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [X] I've updated the documentation if necessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
