lomchik commented on pull request #950: URL: https://github.com/apache/cordova-android/pull/950#issuecomment-701207684
Hi. This commit breaks logging in release mode which is very useful for bug reports. Reason: webView print logs only when `WebView.setWebContentsDebuggingEnabled(true)`. It is enabled [here](https://github.com/apache/cordova-android/blob/80b7a7f6acb43dfc2dfd4fd87261052496f37756/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java#L176-L178) I propose to add instead of this method something like this. ``` @Override public boolean onConsoleMessage(ConsoleMessage consoleMessage) { if (!ApplicationInfo.FLAG_DEBUGGABLE && consoleMessage.message() != null) LOG.d(LOG_TAG, "%s: Line %d : %s" , consoleMessage.sourceId() , consoleMessage.lineNumber(), consoleMessage.message()); return super.onConsoleMessage(consoleMessage); } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
