raphinesse opened a new pull request #1083: URL: https://github.com/apache/cordova-android/pull/1083
### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> We have multiple places where we support both the legacy `android` SDK tool as well as [`avdmanager`](https://developer.android.com/studio/command-line/avdmanager) and [`sdkmanager`](https://developer.android.com/studio/command-line/sdkmanager) from current SDK tools. This makes code more complicated and maintenance more difficult. This PR removes the support for the `android` CLI tool from our code base. After this change, to use `cordova-android` users will need either: - Revision 25.3.0 (March 2017) or greater of the [Android SDK Tools](https://developer.android.com/studio/releases/sdk-tools) - any version of the [new command-line tools](https://developer.android.com/studio#cmdline-tools) which are also included in Android Studio ### Description <!-- Describe your changes in detail --> - `emulator.list_images` now always uses the `avdmanager` binary. - `android_sdk.list_targets` now always uses the `avdmanager` binary. - `check_reqs.check_android` does not consider legacy `android` binary for SDK detection anymore - We do not give error messages that involve using the legacy `android` binary anymore There are multiple opportunities for further simplification after the code removal in this PR. I already have seized some of these in a local branch but I would prefer to open new PRs for these after this is merged. ### Testing <!-- Please describe in detail how you tested your changes. --> - Existing unit and E2E tests pass - The following manual tests give the expected results on my machine: - `node -e "require('./bin/templates/cordova/lib/emulator').list_images().then(console.log)"` - `node -e "node -e "require('./bin/templates/cordova/lib/android_sdk').list_targets().then(console.log)"` - `node -e "require('./bin/templates/cordova/lib/check_reqs').check_android().then(console.log)"` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
