raphinesse opened a new pull request #91: URL: https://github.com/apache/cordova-fetch/pull/91
### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> https://github.com/apache/cordova-lib/issues/859 ### Description <!-- Describe your changes in detail --> - Changes as outlined in the latest hangout - Some adjustments to test expectations to handle minor behavior changes in `npm@7` ### Testing <!-- Please describe in detail how you tested your changes. --> Included test suite. ### TODO - Merge #89 - Test with cli & lib - Add CI test w/ `npm@7`? - Maybe replace a few of the unit tests I threw out here - Check if `pacote` and `npm` are sharing a cache as expected. The test duration actually increased from 90s to 110–120s with this fix, so we are actually spending a bit more extra time than expected - Do something about the two failing expectations `uninstall` seems to be broken with `--no-save` on `npm@7`. Specifically the sequence ```bash cd $(mktemp -d) mkdir node_modules npm i cordova-android --no-save npm un cordova-android --no-save ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
