breautek commented on a change in pull request #1063:
URL: https://github.com/apache/cordova-docs/pull/1063#discussion_r506788596
##########
File path: www/contribute/team.html
##########
@@ -0,0 +1,38 @@
+---
+layout: team
+title: Team
+---
+
+<div class="row">
+ <div class="col-sm-12 text-center">
+ <h1>Team</h1>
+ <p>These are some of people behind Apache Cordova</p>
+ </div>
+</div>
+
+{% for member in site.members %}
+<div class="row">
+ <div class="col-sm-8 col-xs-8">
+ <span>
+ <h2>{{ member.name }}</h2>
+ <p>{{ member.subtitle }}</p>
+ </span>
+ </div>
+</div>
+<div class="row">
+ <div class="col-sm-8">
+ <p>
+ {{ member.content }}
+ </p>
+ </div>
+ <div class="col-sm-3 col-sm-offset-1">
+ <img src="{{ member.imageurl }}"><img>
+ {% if member.twitter %}
+ <a href="{{ member.twitter }}">Twitter</a>
Review comment:
Are we able to use a twitter icon here for the hyperlink instead of
having a textual link or does this raise trademark/copyright concerns?
I think graphically an icon is better than a textual link.
FontAwesome 4.7 is a free set of icons related under MIT (Code)/SIL (Font
files) licenses. I think it's safe to use this for as long as we update our
[attributions](https://cordova.apache.org/attributions/) page. FontAwesome has
a [twitter](https://fontawesome.com/v4.7.0/icon/twitter) icon, among other
social media platforms.
##########
File path: www/contribute/team.html
##########
@@ -0,0 +1,38 @@
+---
+layout: team
+title: Team
+---
+
+<div class="row">
+ <div class="col-sm-12 text-center">
+ <h1>Team</h1>
+ <p>These are some of people behind Apache Cordova</p>
+ </div>
+</div>
+
+{% for member in site.members %}
+<div class="row">
+ <div class="col-sm-8 col-xs-8">
+ <span>
+ <h2>{{ member.name }}</h2>
+ <p>{{ member.subtitle }}</p>
+ </span>
+ </div>
+</div>
+<div class="row">
+ <div class="col-sm-8">
+ <p>
+ {{ member.content }}
+ </p>
+ </div>
+ <div class="col-sm-3 col-sm-offset-1">
+ <img src="{{ member.imageurl }}"><img>
+ {% if member.twitter %}
+ <a href="{{ member.twitter }}">Twitter</a>
+ {% endif %}
+ {% if member.homepage %}
+ <a href="{{ member.homepage }}">Homepage</a>
Review comment:
Same as above, but with a
[home](https://fontawesome.com/v4.7.0/icon/home) icon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
