raphinesse opened a new pull request #1123: URL: https://github.com/apache/cordova-android/pull/1123
### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> `device.install` and `emulator.install` are virtually identical. The only real difference is that `emulator.install` has some retry logic that is supposed to mitigate emulator hangs. The same goes for the unit tests. Furthermore, on the only calling site of these functions, it is easier to call a generic function. Joining these methods reduces the code we have to maintain and makes upcoming refactors easier. ### Description <!-- Describe your changes in detail --> This change replaces `device.install` and `emulator.install` with the generic `target.install`. ### Testing <!-- Please describe in detail how you tested your changes. --> Our unit tests pass. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
