breautek commented on issue #154: URL: https://github.com/apache/cordova-common/issues/154#issuecomment-729679390
I see, I've observed the behaviour but I'm not sure if this is a bug. Plugins in general are responsible for cleaning up after themselves. So I'll be leaving this issue as closed. I think the best course of action is for the plugin to implement the `before_plugin_uninstall` hook which reverts it's change to `AndroidManifest.xml`. However, it looks like you can't simply reuse the `<edit-config>` style to do this... since it appears hooks expects a script file and the recommended way is to provide a NodeJS script. I'm not that familiar with the common codebase, but I *assume* it's possible to use the Config merging code from within a hook. I would ask the people on our [Slack](http://slack.cordova.io/) for advice. https://cordova.apache.org/docs/en/latest/guide/appdev/hooks/index.html ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
