NiklasMerz opened a new pull request #1031: URL: https://github.com/apache/cordova-ios/pull/1031
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> The InAppBrowser used to import the process pool from the wkwebview plugin. No the processpool is in the iOS platform and got renamed. Because it's in the private part InAppBrowser can never import it and use the shared pool. See this issue: https://github.com/apache/cordova-plugin-inappbrowser/issues/751 ### Description <!-- Describe your changes in detail --> I just set the file to public in Xcode. From my understanding this should be public for plugins to use (like IAB to share Cookies). I am not sure if this is the right way to make this public though. Are there any other problems for having this private? ### Testing <!-- Please describe in detail how you tested your changes. --> ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
