brodybits opened a new pull request #544: URL: https://github.com/apache/cordova-cli/pull/544
I am raising this as a quick DRAFT PR, not yet tested: resolves #543 with an ugly workaround TODO: - [ ] update package-lock.json - [ ] test (see below) <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected All ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> This *should* avoid issue #543 which was caused by this issue: https://github.com/sebhildebrandt/systeminformation/issues/443 ### Description <!-- Describe your changes in detail --> see title ### Testing <!-- Please describe in detail how you tested your changes. --> TODO: - [ ] we should reproduce #543 before testing this one - [ ] test this workaround after installing Cordova CLI using the following command: `npm i -g apache/cordova-cli#brodybits-workaround-for-issue-543` - [ ] ensure the build is green on GitHub before merging ### Checklist - [ ] I've run the tests to see all new and existing tests pass - TODO - ~~I added automated test coverage as appropriate for this change~~ - ~~Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)~~ - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - ~~I've updated the documentation if necessary~~ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
