PieterVanPoyer commented on pull request #1113: URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-735295989
Hi @raphinesse thanks for your time. I was also happy with the testcoverage. There were some examples and it was easy to just add my stuff and improve the coverage. And like you said: 'the code is clean'. I must admit, when I was looking for fixing the issue, I was surprised to find the handling of the splashscreens in the cordova-android lib and not in the plugin code. Unfortunately I cannot shed any light on that matter. I think making this stuff more generic wouldn't be a real improvement, and I don't exactly know how you'd like that to be. On the other hand, taking the time to make an issue in the splashscreen plugin to move the splashscreen code to the right place would be a good first step. When the handling (copying, deleting) of splashscreens is in the plugin, it can be less generic, because that's what the plugin should do. Handling splashscreens. Kind regards Pieter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
