zoltan-mihalyi opened a new pull request #180: URL: https://github.com/apache/cordova-electron/pull/180
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected - Windows (electron window is hidden) - others (stdio is ignored) ### Motivation and Context - On windows platform using nodejs 11+, the electron window does not appear. - Standard output from electron is ignored ### Description - `windowsHide: false` makes the electron window appear on windows. - `stdio: 'inherit'` makes the output of electron appear in the console. ### Testing I manually tested my changes on windows. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
