erisu opened a new pull request #183: URL: https://github.com/apache/cordova-electron/pull/183
### Motivation, Context & Description Use `prepare` hook-script instead of `prepack`. While `prepack` works, `prepare` covers an important case that is needed when installing via `git` or `local`. #### npm hook-scripts differences > **prepack** > > * Runs BEFORE a tarball is packed (on "npm pack", "npm publish", and when installing a git dependencies). > * NOTE: "npm run pack" is NOT the same as "npm pack". "npm run pack" is an arbitrary user defined script name, where as, "npm pack" is a CLI defined command. > **prepare** (since `[email protected]`) > > * Runs BEFORE the package is packed > * Runs BEFORE the package is published > * Runs on local npm install without any arguments > * Run AFTER prepublish, but BEFORE prepublishOnly > * NOTE: If a package being installed through git contains a prepare script, its dependencies and devDependencies will be installed, and the prepare script will be run, before the package is packaged and installed. The additional important cases that needs to be covered which `prepare` covers is. > * Runs on local npm install without any arguments and > * NOTE: If a package being installed through git contains a prepare script, its dependencies and devDependencies will be installed, and the prepare script will be run, before the package is packaged and installed. ### Testing - `npm t` - `npm pack` - `npm install <git>` - `npm install <local>` ### Checklist - [x] I've run the tests to see all new and existing tests pass ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
