[ 
https://issues.apache.org/jira/browse/CB-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725675#comment-13725675
 ] 

Michael Brooks commented on CB-3762:
------------------------------------

I've applied the cordova-docs patch as commit 
[717182|https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;a=commit;h=717182904485303df0fe392a8043d5dfb61f335e].

Can someone please review and apply the JS fix.
                
> notification.prompt doesn't accept an empty string for default text
> -------------------------------------------------------------------
>
>                 Key: CB-3762
>                 URL: https://issues.apache.org/jira/browse/CB-3762
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Dialogs
>    Affects Versions: 2.7.0, 2.8.0
>            Reporter: Todd Miller
>            Assignee: mike billau
>            Priority: Minor
>             Fix For: 3.1.0
>
>
> Specifying "" as the last parameter for navigator.notification.prompt, the 
> prompt dialog will still show "Default Text" in the text input box. However, 
> putting a string of just a single space works (but also results in a space in 
> the text box).
> In additional seems like the default of "Default Text" isn't the best choice 
> from UX perspective. A default of an empty text box would make more sense.
> Changing line 5909 in cordova.js from:
> var _defaultText = (defaultText || "Default text");
> to
> var _defaultText = (defaultText || "");
> Resolves the issue and gives a blank text box by default. Documentation would 
> also need to be updated with the new default if this is adopted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to