erisu edited a comment on issue #185: URL: https://github.com/apache/cordova-electron/issues/185#issuecomment-758436168
This request has been mentioned a few times but it is a bit challenging. There are two places where the version is defined. * The `package.json` of the platform. This dependency is used for the `cordova run` command. Currently, the pinning contains `^` which accepts new minor and patches. This `^` is problematic and should be hard pin to follow the second location. The reason it is problematic is that the run command may eventually fail with no changes to the user's project. * The `build.json` is hard pinned. This is used for building the packages. Because it is hard pinned, it is consistent and should not fail unexpectedly if there is no change to the project. This is used in the `cordova build` command. If we allow the users to specify a version, we can not guarantee that the project will build or run successfully. Nor can we provide speedy support for versions that were not tested or approved. Should something be implemented, which I am not against, I would rather refer to it as an experimental feature. Any issues reported by using a version that is not been tested and approved might get closed or thrown in a backlog. I had taken a look at solutions before, for example, using a post-install script to manage to install the default version or targeted version defined in an environment variable, project's `package.json` or `config.xml`, but the post-install script was not being executed as expected. Shortly, I will be changing the pinning in `package.json` to be hard pinned to resolve the current issue where the `cordova run` outcome might not match with `cordova build`. Whatever solution you had in mind will need to support both run and build and potentially resolving the builder dependency to match with the electron version. I think sometimes changes in Electron might require changes with the builder dependency. They might go hand in hand. All in all, I think the default pinned version is supported and anything else could not be guaranteed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
