[ 
https://issues.apache.org/jira/browse/CB-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727917#comment-13727917
 ] 

Andrew Grieve commented on CB-3506:
-----------------------------------

Looks great Steve, few nits:

#1 - 
Change: var opt = registerRepoFlag(optimist)
to: var opt = optimist

since you don't use the -r flag.

#2 -
Might be good to have a check right at the start to ensure the built .zip to 
upload exists

#3 -
Might be better to end off with doing an "svn status" and a print-out of the 
command to execute in order to commit (instead of committing itself).
                
> Add a command to coho for uploading a release candidate
> -------------------------------------------------------
>
>                 Key: CB-3506
>                 URL: https://issues.apache.org/jira/browse/CB-3506
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Coho
>            Reporter: Andrew Grieve
>            Assignee: Steve Gill
>            Priority: Minor
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to