breautek commented on pull request #1173: URL: https://github.com/apache/cordova-android/pull/1173#issuecomment-806809921
The tests uses fake paths cause they don't actually create files, they do this by mocking the real implementations of the filesystem. Looks like the tests will have to be updated. I'd probably would spy on `fs.ensureDirSync` and `fs.writeFileSync` to prevent actual file IO. (in most of those tests we don't actually care if `writeNameForAndroidStudio` because testing that is out of scope) Then ideally we will have some specific tests that will test the new `writeNameForAndroidStudio` function itself by ensuring those two filesystem api calls are called with the proper parameters. We don't need to test if the implementation of those two FS calls works because we can assume NodeJS / fs-extra plugin authors have done their own testing, so in theory as long as we call them with the proper parameters, then everything **should** be okay :grin: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
