breautek commented on a change in pull request #1173:
URL: https://github.com/apache/cordova-android/pull/1173#discussion_r601753149
##########
File path: spec/unit/create.spec.js
##########
@@ -300,4 +301,23 @@ describe('create', function () {
});
});
});
+
+ describe('writeNameForAndroidStudio', () => {
+ var project_path = path.join('some', 'path');
Review comment:
> Well, I love ES6 (and TypeScripe) but when I always try to follow the
pattern of existing code and found that existing code is using var mostly and
using snake case variables, so used var. Thanks anyways. Updated this for new
code.
Yah, `var` refactoring is a work in progress which I think is why we don't
have an eslint config (?) I was kinda surprised the eslint didn't produce an
error on it tbh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
